Throw exception for CraftMagicNumbers#getMappingsVersion#12676
Merged
kennytv merged 1 commit intoPaperMC:dev/1.21.6from Jun 17, 2025
JRoy:remove-md5-magic-string
Merged
Throw exception for CraftMagicNumbers#getMappingsVersion#12676kennytv merged 1 commit intoPaperMC:dev/1.21.6from JRoy:remove-md5-magic-string
kennytv merged 1 commit intoPaperMC:dev/1.21.6from
JRoy:remove-md5-magic-string
Conversation
jpenilla
approved these changes
Jun 15, 2025
github-project-automation
bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
Warriorrrr
approved these changes
Jun 15, 2025
AlexProgrammerDE
approved these changes
Jun 16, 2025
Contributor
AlexProgrammerDE
left a comment
AlexProgrammerDE
left a comment
There was a problem hiding this comment.
Would be great to have this in for 1.21.6, so that plugin devs can properly fallback.
kennytv
approved these changes
Jun 17, 2025
github-project-automation
bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after hard fork it makes no sense to have this. devs can use ServerBuildInfo#minecraftVersionId if they need a string that will change every version