Fix isInteractable for copper chests #13325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
approved these changes
Dec 7, 2025
Contributor
|
Tested against the entire registry as well 👍 |
Contributor
|
Let me know if you need this backported to 1.21.10. |
github-project-automation
bot
moved this from PR Party candidate
to Merged
in Paper PR Queue
Contributor
Author
|
A backport to 1.21.10 would be very welcome! |
lynxplay
added a commit
that referenced
this pull request
Dec 19, 2025
Co-authored-by: Bjarne Koll <[email protected]>
Contributor
|
14a10f4 👍 |
Contributor
Author
|
Thank you! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
isInteractablemethod ofBlockTypereturns false for the 4 unwaxed copper chest variants. The issue is thatisInteractableonly checks for certain methods in the block's class and its super class, but for unwaxed copper chests (implemented byWeatheringCopperChestBlock) those methods are higher up the class hierarchy.I compared the truth values for all blocks before and after this change and verified that only unwaxed copper chests were affected. Hopefully this change also makes
isInteractableless liable to return false negatives in the future.