Fix: clamp excessive entity velocities to [-4,4] to prevent plugin-caused explosive launches (#13270) #13328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used explosive launches (PaperMC#13270) - Clamp per-axis velocities to [-4.0, 4.0] for non-projectile/non-minecart entities in CraftEntity#setVelocity. - Preserve existing CraftServer.excessiveVelEx warning when unsafe velocities are attempted. - Add a small clamp helper. This prevents plugins from causing inconsistent or extreme player launches while keeping projectiles/minecarts unchanged. Tested with local runDev and test-plugin harness to confirm NMS deltaMovement is clamped to 4.0.
Member
|
Welcome to paper! Unfortunately, I don't think this is quite the right fix for this issue, velocities above/below (-)4 are valid and shouldn't be clamped here like that. I think some more discussion would be useful in the original issue how/if we want to fix this, the root issue is trivially fixable on the plugin's side at least. Thank you for your contribution regardless. |
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clamp per-axis velocities to [-4.0, 4.0] for non-projectile / non-minecart entities in CraftEntity#setVelocity.
This prevents plugins from applying extreme velocities (e.g. new Vector(0, 100, 0)) that can cause inconsistent or explosive player launches and server-side instability.
Fixes: #13270