Fixed blocks_attacks non-vanilla behaviour #13443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for your PR! However, due to the sensitive nature of all of the damage related code due to our fun legacy mess we will be closing this PR as we would like the paper team to instead resolve this issue. Additionally, for future reference, please make sure your code contains paper comments and english comments. It appears that your code most likely has AI generated comments that alludes to it being AI generated in the first place. (Which causes a behavior change) |
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13426 : This PR fixes an issue where partially blocked attacks (when damage is reduced but still > 0) were treated as fully blocked