Add config for chunk unload drains per tick #13465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Changes to moonrise need to be PRed to its repo, otherwise we'll loose them on next re-apply of the patch https://github.com/Tuinity/Moonrise |
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
Author
|
Uh, we need to add the configuration entry to Paper WorldConfiguration. Should I just pick another patch commit? |
Contributor
|
No, this is not about the chosen patch, this is about the moonrise to paper flow. The moonrise solution to this is an addition to the PlatformHooks type, which serves as the common config interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After checking my memory dump, I found that the pending unlock chunks takes up most of my memory. I have a lot of players who love to travel around with elytra.
There's a
maxAutoSaveChunksPerTickoption, so I think theseUnloadChunksPerTickoptions make sense.After setting
maxUnloadChunksPerTickFactorto 1.0 on my server, my memory comes very healthy.