wip: config support for how many max channels a player can register#1543
Closed
SpigotRCE wants to merge 1 commit intoPaperMC:dev/3.0.0from
Closed
wip: config support for how many max channels a player can register#1543SpigotRCE wants to merge 1 commit intoPaperMC:dev/3.0.0from
SpigotRCE wants to merge 1 commit intoPaperMC:dev/3.0.0from
Conversation
SpigotRCE
changed the title
Warriorrrr
reviewed
Apr 9, 2025
Member
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
This seems like something better suited as system property, all the different small changes you made also make it harder to find what's actually changed.
It's also normal "etiquette" when making a change to include some sort of message in the pr description, right now it seems you arbitrarily lowered the limit to 128 which seems more likely to interfere with mods.
Contributor
Author
|
Alright, I'll do it by tomorrow cause I was on vacation. |
SpigotRCE
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.