Implement missing writabilityChanged() and add backlog logging with BACKPRESSURE_LOG to all writabilityChanged() implementations.#1745
Merged
electronicboy merged 1 commit intoPaperMC:dev/3.0.0from Mar 18, 2026
Conversation
…ACKPRESSURE_LOG to all writabilityChanged() implementations.
electronicboy
approved these changes
Mar 18, 2026
Contributor
Author
|
There are 12 classes that implement |
Member
|
Most of the other handlers don't have another connection directly involved with them, so we don't need to worry about telling the other side to stop doing stuff as there is no other side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
velocity.log-server-backpressureflag already existed and was only checked byBackendPlaySessionHandlerand used inBackendPlaySessionHandler#writabilityChanged, now every implementation of writabilityChanged() logs, and this PR adds the missing implementations for ConfigSessionHandler and ClientConfigSessionHandler.See #1742