Skip to content

Implement missing writabilityChanged() and add backlog logging with BACKPRESSURE_LOG to all writabilityChanged() implementations.#1745

Merged
electronicboy merged 1 commit intoPaperMC:dev/3.0.0from
WouterGritter:missing-handler-writabilitychanged
Mar 18, 2026
Merged

Implement missing writabilityChanged() and add backlog logging with BACKPRESSURE_LOG to all writabilityChanged() implementations.#1745
electronicboy merged 1 commit intoPaperMC:dev/3.0.0from
WouterGritter:missing-handler-writabilitychanged

Conversation

@WouterGritter
Copy link
Contributor

@WouterGritter WouterGritter commented Mar 18, 2026

The velocity.log-server-backpressure flag already existed and was only checked by BackendPlaySessionHandler and used in BackendPlaySessionHandler#writabilityChanged, now every implementation of writabilityChanged() logs, and this PR adds the missing implementations for ConfigSessionHandler and ClientConfigSessionHandler.

See #1742

…ACKPRESSURE_LOG to all writabilityChanged() implementations.
@WouterGritter
Copy link
Contributor Author

There are 12 classes that implement MinecraftSessionHandler. Should we implement writabilityChanged() in all 12 of them? Before this PR, only 2 classes implemented this, and after this PR only 4 classes implement the method. Was there any reason for omitting this method in some (most) session handlers?

@electronicboy
Copy link
Member

Most of the other handlers don't have another connection directly involved with them, so we don't need to worry about telling the other side to stop doing stuff as there is no other side

@electronicboy electronicboy merged commit 99bd030 into PaperMC:dev/3.0.0 Mar 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants