feature(minimessage): Rainbow tag saturation argument#1210
Open
Privatech38 wants to merge 5 commits intoPaperMC:main/4from
Open
feature(minimessage): Rainbow tag saturation argument#1210Privatech38 wants to merge 5 commits intoPaperMC:main/4from
Privatech38 wants to merge 5 commits intoPaperMC:main/4from
Conversation
…tion]> and implemented it to color()
…ag. You are now required to provide [phase] or [!] argument before specifying [saturation] argument
kezz
approved these changes
Apr 11, 2025
Member
kezz
left a comment
kezz
left a comment
There was a problem hiding this comment.
LGTM - needs an associated docs PR before merge. Thanks!
Contributor
Author
|
KyoriPowered/adventure-docs#210 documentation PR |
Privatech38
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a saturation argument (optional) to
rainbowtag. It simply sets the saturation value of eachHSVLiketo the argument value or 1 if omited.Why? Max saturation can be unpleasant for eyes, especially on longer texts.
The syntax would follow
<rainbow:[!][phase]:[saturation]>.Since the current algortihm has default values if argument is of lenght 0 this allows for such syntax:
<rainbow:0:0.65><rainbow::0.65>It also uses
Float#parseFloatmethod meaning any legal Java float representation is allowed:.65,0.65f,1etc.This PR also partially closes #1038