Allow selecting patch line (ranges) and linking to them#49
Merged
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR implements functionality to allow selecting patch line ranges and linking to them via URL hashes. The main changes include migrating from Svelte actions to attachments, adding selection state management, and implementing URL-based navigation to specific file lines.
- Migrates event handlers from
svelte/actiontosvelte/attachmentsAPI - Implements line selection functionality with URL hash support for linking
- Adds visual indicators for selected lines in the diff viewer
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Sidebar.svelte | Migrates focusFileDoubleClick from Action to Attachment; adds selection clearing on file double-click |
| FileHeader.svelte | Adds selectHeader function to set file selection when clicking file headers |
| DiffWrapper.svelte | Binds selection state between viewer and ConciseDiffView component |
| util.ts | Converts resizeObserver from Action to Attachment pattern |
| open-diff-dialog.svelte.ts | Adds linkable flag to diff metadata; preserves URL hash in navigation |
| diff-viewer.svelte.ts | Implements selection state management, URL hash parsing/writing, and jump-to-selection logic |
| ShikiThemeSelector.svelte | Updates resizeObserver usage to new Attachment API |
| concise-diff-view.svelte.ts | Adds LineRef types, selection logic, line reference parsing/writing functions |
| ConciseDiffView.svelte | Implements selection UI with visual indicators and jump-to-selection behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
improve linking consistency, add Go>Go to Selection menu action
jpenilla
force-pushed
the
feat/line-selection-linking
branch
from
c6ad456 to
1bead89
Compare
jpenilla
force-pushed
the
feat/line-selection-linking
branch
from
12b974f to
30f3c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #35