feat: Add Adventure docs #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
zlataovce
reviewed
Apr 22, 2025
zlataovce
reviewed
Apr 22, 2025
Strokkur424
force-pushed
the
feat/adventure
branch
3 times, most recently
from
ce0ed19 to
d876719
Compare
Strokkur424
force-pushed
the
feat/adventure
branch
2 times, most recently
from
16ad110 to
300014f
Compare
Strokkur424
force-pushed
the
feat/adventure
branch
from
b274062 to
96d86e0
Compare
Strokkur424
force-pushed
the
feat/adventure
branch
from
1400583 to
8f7b197
Compare
Strokkur424
force-pushed
the
feat/adventure
branch
from
cb6c56c to
a245370
Compare
Strokkur424
force-pushed
the
feat/adventure
branch
from
f662289 to
56caa06
Compare
Strokkur424
force-pushed
the
feat/adventure
branch
from
49fce08 to
9bdf488
Compare
kezz
approved these changes
Oct 3, 2025
Member
kezz
left a comment
kezz
left a comment
There was a problem hiding this comment.
Minor changes, but otherwise LGTM! Thank you :D
olijeffers0n
reviewed
Oct 3, 2025
olijeffers0n
approved these changes
Oct 3, 2025
zlataovce
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #569.
Differences between the current Kyori docs:
Whilst the index pages exist path wise, they aren't directly accessible via the side bar. I am not sure how, or even if it is possible, to do that, so that's something for scorp to fix 😀.On a few of the serialiser pages (only on those where a dependency is displayed via the <AdventureDependency /&mt; tag, I had to add an extra code block displaying the way to retrieve an instance, as without a code block, the imported code block is not rendered correctly. This seems to be an Astro/expressive-code related bug, but I still needed a non-intrusive workaround.reported, waiting for fixOn the MiniMessage format page, certain screenshots are aligned/sized slightly differently than in the Kyori ones. If desired, I can try to conclude more parity, but that wasn't a priority when I initially wrote the docs.resolvedTODO:
Soft-Blocked on:
<Code>component styles missing when settingemitExternalStylesheet: falseexpressive-code/expressive-code#342 - No longer a full blocker, as we can avoid the bug. But once this is merged, all workarounds should be reverted back.