Skip to content

feat: basic_node allocation and aug_node iterate method #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: basic_node allocation and aug_node iterate method #4

wants to merge 1 commit into from

Conversation

RomaLzhih
Copy link

  • The basic::compressed_node should allocate memory based on its size, rather than the hard-coded value, which may bring trouble when the developer wants to change the node structure.
  • When traversing the tree in augmented_node, one should cast the node to the augmented_node type rather than the basic node, as this may incur a different offset when access the encoded_data.

@RomaLzhih
feat: basic_node allocation and aug_node iterate method
f67b7c0 
- The basic_node should alloc memory based on its size, rather than the
hard-coded size, which may bring trouble when developer may want to
change the node structure.
- When traverse the tree in augmented_node, one should cast the node to
augmented_node type rather the basic node, as this may incur different
offset problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RomaLzhih