-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[READY FOR REVIEW] Full Species Resprite + Multiply Blending #31373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…-species-resprite + slime people
|
As it stands with slime sprites, I feel they're a direct downgrade to what we have currently. The sprites themselves on their own aren't bad but they're entirely different than Slime People as they are now, not just "Kind of improved sprite with better color mechanics" or such. They look like solid globs of paint. They're well done/aren't bad sprites, this isn't a dig at the sprite. The problem is what they're meant to replace in their current state they just ain't there yet to me. Transparency needs to be redone, Alfie did mention this being possible to fix already so I'm hopeful it can/will be. In it's current state comparatively however it's very much a "If it ain't broke, don't fix it." in terms of looks for what it's going to be replacing. They look nothing alike. Mostly posting this here to echo my concerns from the Discord so it's in a more manageable/easier to find place. Again, the spritework is solid. If it wasn't meant to be replacing Slime People I'd be all for it. But given that it is, I feel it still needs work as mentioned above. Vulps however look quite a bit better and more alien/humanoid dogbeast thing VS straight up "I'm an anthro dog" that they currently are. |
|
Slime people are also kind of messed up right now, not from the sprites, but from somewhere in code drawing them multiple times. I have found some of the occasions where they're drawn multiple times but not all of them. I'm still looking. |
Is this from my code related to the PR or an unrelated issue? |
It's not an issue that you caused, but an issue that makes it difficult to evaluate whether the new slime sprites are good, because their transparency isn't represented properly ingame. |
It's because MDU-333 uses entirely Ward-Takahashi parts. |
I don't see the correlation. Bright saturated colors still work with ICON_MULTIPLY and will absolutely work with Ward-Takahashi. |
I'm sorry that you think that this change makes your character look "a lot worse". I do not know how I can objectively accommodate for this feedback. |
|
Do you see how the contrast ramp is pretty severe between the lighter tones and the darker ones? There's also no highlights. It starts at a midtone and then has four darker shades. |
This is something that will 100% a LOT of IPC feedback from numerous players to see if this change will work properly. I'd say be prepared to walk-back the IPC changes completely given what alfalfa had to go through |








What Does This PR Do
Project discussion for further detail
Vulpkanin sprites, IPC sprites, and code done entirely by @Alecksohs
This PR moves body color from ICON_ADD to ICON_MULTIPLY. In doing so, species that use body color need to be resprited to a proper palette that will work well with ICON_MULTIPLY. This opportunity is being taken to resprite and better shade the following species, as well as their markings and/or tails:
Why It's Good For The Game
ICON_MULTIPLY is vastly superior over ICON_ADD for color consistency and will cause spriting quality to skyrocket. Many species sprites are old and do not hold up with the current spriting standards. If we don't make this change now, I don't imagine it will ever change.
Images of changes
Testing
Tested each species individually, played with colorful body colors, markings, tail types, and facial hairs.
Declaration
Changelog
🆑
tweak: Species that use body color now use ICON_MULTIPLY for color blending
imageadd: Resprite Vulpkanin
imageadd: Resprite Slime People
imageadd: Resprite Unathi
imageadd: Resprite Tajaran
imageadd: Resprite IPC
imageadd: Resprite Skrell
/:cl: