use ABSTRACT_TYPE_DESC in more places #31409
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

What Does This PR Do
This PR uses
ABSTRACT_TYPE_DESCfor more objects. The remaining descriptions I saw which had a "report this to github" type message on them are for things that either aren't atoms and thus wouldn't go through SSatoms, or are meant to be instantiated, just not accessed by players (internal battery cells for flayer arms etc).It also moves the behavior on the base /obj/item/book spawners into random spawners for manuals and library books, and provides the UpdatePaths and map changes for them.
It also removes a generic cigarette pack on Cere and replaces it with a robust pack.
Why It's Good For The Game
More warnings for abstract items being initialized in game. Less of the oldcode /obj/item/basetype that generates a random version of its subtypes.
Images
the result of using the manual, library book, and triple library book spawners.

Testing
Visual inspection.
Declaration
Changelog
NPFC