Skip to content

Conversation

@warriorstar-orion
Copy link
Contributor

@warriorstar-orion warriorstar-orion commented Jan 7, 2026

What Does This PR Do

This PR uses ABSTRACT_TYPE_DESC for more objects. The remaining descriptions I saw which had a "report this to github" type message on them are for things that either aren't atoms and thus wouldn't go through SSatoms, or are meant to be instantiated, just not accessed by players (internal battery cells for flayer arms etc).

It also moves the behavior on the base /obj/item/book spawners into random spawners for manuals and library books, and provides the UpdatePaths and map changes for them.

It also removes a generic cigarette pack on Cere and replaces it with a robust pack.

Why It's Good For The Game

More warnings for abstract items being initialized in game. Less of the oldcode /obj/item/basetype that generates a random version of its subtypes.

Images

the result of using the manual, library book, and triple library book spawners.
2026_01_07__11_26_21__Paradise Station 13

Testing

Visual inspection.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting review This PR is awaiting review from the review team label Jan 7, 2026
@ParadiseSS13-Bot ParadiseSS13-Bot added the Map Edit This PR will modify a map label Jan 7, 2026
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 7, 2026
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Jan 9, 2026
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 15, 2026
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-Status: Awaiting merge This PR is ready for merge Map Edit This PR will modify a map Merge Conflict This PR is merge conflicted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants