Reduced the number of redistributions in spectral helper slightly #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownbaerchen
added a commit
to brownbaerchen/pySDC
that referenced
this pull request
Oct 26, 2025
#!!!!!!!!!! WARNING: RUFF FAILED !!!!!!!!!!: #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:494:9: E722 Do not use bare `except` # | Parallel-in-Time#492 | k[_s > 1e-16], _s[_s > 1e-16], color=last_line.get_color(), ls=last_line.get_linestyle(), label=label Parallel-in-Time#493 | ) Parallel-in-Time#494 | except: # | ^^^^^^ E722 Parallel-in-Time#495 | pass # | # #pySDC/projects/GPU/analysis_scripts/compare_RBC3D.py:593:5: F841 Local variable `Delta_Nu` is assigned to but never used # | Parallel-in-Time#591 | t = data['t'] Parallel-in-Time#592 | avg_Nu = np.array([np.mean(Nu[40 : 40 + i + 1]) for i in range(len(Nu[40:]))]) Parallel-in-Time#593 | Delta_Nu = np.array([abs(avg_Nu[i + 1] - avg_Nu[i]) for i in range(len(avg_Nu) - 1)]) # | ^^^^^^^^ F841 Parallel-in-Time#594 | # ax.plot(data['t'][40:-1], Delta_Nu / avg_Nu[:-1]) Parallel-in-Time#595 | # ax.plot(data['t'], np.abs(avg_Nu - avg_Nu[-1]) / avg_Nu[-1]) # | # = help: Remove assignment to unused variable `Delta_Nu`:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redistributions use alltoall communication and are expensive. By reducing these, I could see slightly better parallel efficiency in Rayleigh-Benard.