-
Notifications
You must be signed in to change notification settings - Fork 37
Firedrake coupling #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firedrake coupling #513
Conversation
example with short tutorial.
|
Prettttttty awesome! |
|
Looks fine by me. Having a first structure for a coupling with firedrake and gusto is already some nice input, eventually we can improve that later ... |
|
I would appreciate if we could merge this sooner rather than later. I cleaned up the Gusto coupling a lot today. I basically have to make sure the parameters in the tutorial are sensible and then I could open a PR for this from tomorrow. |
This PR includes things that are needed to couple pySDC and Firedrake and a small heat equation example. Seems I cannot add @jshipton as a reviewer, but you are very welcome to add comments anyways.
What is needed:
Also included in this PR:
Not included in this PR
Coupling between pySDC and Gusto. While this works in principle, it needs a lot of cleanup and will be a slightly larger PR. So we decided to merge the two couplings separately. We did not do any more elaborate equations here than heat equation because including elaborate versions of equations is one of the features of Gusto and that will come with the Gusto coupling.