-
Notifications
You must be signed in to change notification settings - Fork 37
Add Python 3.13 to core test pipeline #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Let's kick 3.9. |
|
+1 on the project tests for one Python version only. Also, using the latest version for project test should simplify maintaining on the long term IMO => once a year, we upgrade the latest version, and eventually correct the projects that need adaptation. Just need a proper clarification on when we upgrade every year. |
|
Fine by me. Projects should have a way to specify their (set of) Python versions that should be tested. pySDC's core should be tested against as much as we can, though. |
But what about when a project required some python versions that are not supported anymore ? |
|
You mean like, |
|
But then, what's the harm? if the core of pySDC still works with that version? The more the better, no? |
|
It's straightforward to set the Python version individually by simply adding However, why not treat the Python version like any other dependency? If we don't specify a version, micromamba will select the latest reasonable version. Then we either support the latest that users get, or we react once the pipeline fails for some reason and restrict to an older version. In any case, I suggest we don't remove 3.9 from the core tests because it is still supported. |
|
Fine by me. Wild, but fine. |
|
Let's get this merged! |
* Add testing for Python 3.13 to pipeline * Try removing mpi4py restriction * Test * Testing projects with latest Python version only
According to the status of Python versions, Python 3.13 is supported at least to some extend. When I last installed a fresh pySDC environment without explicitly specifying a Python version, I even ended up with 3.13. Therefore, I suggest we better test it to accommodate future users.
However, the pipeline is already too large as is, with some project tests taking a very long time. Therefore, I did not add 3.13 to those tests. In fact, I would be open to stop doing the project tests with all supported Python versions. IMHO, it would suffice to use the latest version (only 3.13 in this case) or to allow projects to specify a supported Python version.