Immediately flush debug messages #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the code crashes, i.e. does not orderly finish, messages in the log that have not yet been flushed may not get flushed at all. Therefore, I was still using print statements a lot of the time which I removed when I was done.
The better approach is to flush all output immediately when running with debug output. Then, rather than adding temporary print statements during debugging, we can add meaningful messages and leave them in.
Now immediate flushing adds some overhead, I imagine, but presumably you don't care so much about performance when using debug output.
So this PR adds a handler for the loggers that immediately flushes if we use debug output, but it also gives a warning that this degrades performance.
Sadly, I don't know how to test this. If anyone has an idea, let me know!