Infrastructure for 3D RBC #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the planned paper with lots of experiments with 3D RBC. It implements configurations for this in the existing GPU project as well as processing of the data.
In simulations, the solution is written to disk every 0.5 free fall times. Afterwards, the quantities such as Nusselt number etc. are computed from this and the results are written to a pickle file from which they can be conveniently plotted. I.e.: run and process simulation on the HPC machine, copy the pickle file to your laptop and analyze it there.
Tests generate both data and the processed data. I was inspired by @tlunet to use pytest fixtures for this. They are indeed very nice!
Notice that not much in terms of content for the paper is here yet. Indeed there is not much content for it currently. This will come over time in smaller PRs. This PR ist just the infrastructure around it all.
Also, I added a stiffly accurate IMEX Euler version for this.