Update sgrid renaming tooling to work with node_coordinates #2466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
commented
Jan 13, 2026
| return dims | ||
|
|
||
|
|
||
| @overload |
Contributor
Author
There was a problem hiding this comment.
These were moved to be directly over the _metadata_rename_dims function (as this is how @overloads work).
Wasn't flagged before since we're not (yet) running mypy
Docs reference generation wasn't ignored before
- Update Grid*DMetadata.rename_dims to .rename - Update sgrid.rename_dims to sgrid.rename - Add test
VeckoTheGecko
force-pushed
the
000-sgrid-rename
branch
from
bda8cd2 to
0e858c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the tooling in
sgridwas used for the renaming of dimensions. Now that we're also parsingnode_coordinates- which aren't dimensions - we need to make this tooling more flexible so that we can handle renaming of any dimension/coordinate name listed in the metadata.This PR implements these changes, and updates all local variable names/error messages accordingly
Notable changes:
Grid*DMetadata.rename_dimsto.renamesgrid.rename_dimstosgrid.rename(along with internal xarray call)See commit history for full info
Done to help along #2460