Skip to content

update location param to geographic_coordinates for prop search v2 endpoint #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhagyasharma merged 6 commits into from
May 8, 2025
Merged

update location param to geographic_coordinates for prop search v2 endpoint #85

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71c359f
update location param to geographic_coordinates for prop search v2 en…
parcld May 8, 2025
b3f3daf
rm location from args list
parcld May 8, 2025
8ed09a2
ruff fmt
parcld May 8, 2025
79cfca6
update tests to use geo_coordinates
parcld May 8, 2025
b7c7d39
update geo_coordinates param + tests
bhagyasharma May 8, 2025
8d9fc69
add parcl_id + geo_coords to example
bhagyasharma May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### v1.14.1
- Update `property_v2.search` endpoint params.

### v1.13.0
- Add support for `property_v2.search` endpoint.

Expand Down
2 changes: 1 addition & 1 deletion parcllabs/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = "1.14.0"
VERSION = "1.14.1"
10 changes: 5 additions & 5 deletions parcllabs/services/properties/property_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def _build_search_criteria(
self,
parcl_ids: list[int] | None = None,
parcl_property_ids: list[int] | None = None,
location: dict[str, float] | None = None,
geo_coordinates: dict[str, float] | None = None,
) -> dict[str, Any]:
"""Build and validate search criteria."""
data = {}
Expand All @@ -155,8 +155,8 @@ def _build_search_criteria(
if parcl_property_ids:
data["parcl_property_ids"] = parcl_property_ids

if location and all(k in location for k in ["latitude", "longitude", "radius"]):
data.update(location)
if geo_coordinates:
data["geo_coordinates"] = geo_coordinates

return data

Expand Down Expand Up @@ -340,7 +340,7 @@ def retrieve(
data = self._build_search_criteria(
parcl_ids=parcl_ids,
parcl_property_ids=parcl_property_ids,
location=location,
geo_coordinates=location,
)

# Build filters using all provided parameters
Expand All @@ -355,7 +355,7 @@ def retrieve(
"radius",
"params",
"data",
"location",
"geo_coordinates",
]:
kwargs.pop(key, None)

Expand Down
Loading