Skip to content

Conversation

@zhibindai26
Copy link
Contributor

  • create a new var called auto_paginate that is set based on what the user provides as the limit.
  • if no limit is set, auto_paginate is set to True
  • if a limit is set, auto_paginate is set to False
  • The auto pagination will run if auto_paginate is True and there is more data to retrieve
  • Update tests

return max_limit, auto_paginate

# If limit exceeds maximum, cap it
if limit > max_limit:
Copy link
Contributor Author

@zhibindai26 zhibindai26 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit input is managed by the request schema; it's not possible to pass in a value greater than max_limit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-08-14 at 2 35 28 PM

zshamroukh
zshamroukh previously approved these changes Aug 14, 2025
zshamroukh
zshamroukh previously approved these changes Aug 14, 2025
@zhibindai26 zhibindai26 merged commit f262bd3 into main Aug 14, 2025
1 check passed
@zhibindai26 zhibindai26 deleted the fix/limit-pagination branch August 14, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants