Search Improvements

[wordsandnumbers]

TODO

• Add Tests

Fixes #865

[wordsandnumbers]

Seems to work just fine by matching on the label only. 🤷 I added 10 results which addresses the issues in #865

[Eric-Arellano]

Thanks for working on this 🙌 I may take a few days to review because I leave for a one month sabbatical on Friday so am rushing around to finish things.

Regarding the customProperties, this was very intentional so that you can search, for example, "California" and it will look up places that have the state California. See #801. Otherwise, Choices.js uses prefix-matching, so wouldn't match California because the total phrase does not start with California.

I have not closely looked into Tony's frustrations in #865, so I can't give a particular recommendation for how to fix it. But ideally we could preserve the benefits of #801 while addressing Tony's feedback.

[wordsandnumbers]

Thanks for working on this 🙌 I may take a few days to review because I leave for a one month sabbatical on Friday so am rushing around to finish things.

Regarding the customProperties, this was very intentional so that you can search, for example, "California" and it will look up places that have the state California. See #801. Otherwise, Choices.js uses prefix-matching, so wouldn't match California because the total phrase does not start with California.

I have not closely looked into Tony's frustrations in #865, so I can't give a particular recommendation for how to fix it. But ideally we could preserve the benefits of #801 while addressing Tony's feedback.

@Eric-Arellano: Obviously not a rush! Also: Hi! 👋 Nice to meet you via github PR 😆 !
I figured there was a reason you added the customProperties but it wasn't clear what the expectations were. I'll work on a test so we can make sure it meets them.

Have fun on sabbatical!