Fix PHPStan errors on PHP 8.3 and above#3414
Conversation
📝 WalkthroughWalkthroughThe PHPStan configuration file was updated to add a new entry for Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
alecgeatches
left a comment
There was a problem hiding this comment.
Thank you for figuring out the configuration change we needed!
…p8-3-and-above" (2268223)
Description
@alecgeatches had reported that PHPStan was returning errors on PHP 8.3 and above, similar to:
Turns out the root of the issue is the introduction of typed constants in PHP 8.3. Since we need to stick to older PHP versions, I used the
constant_typesetting to neutralize the errors.Motivation and context
Fix our commit workflow from breaking on PHP8.3+.
How has this been tested?
Tested on PHP 8.3/8.4 with and without the fix.
Summary by CodeRabbit