Skip to content

Fix PHPStan errors on PHP 8.3 and above#3414

Merged
acicovic merged 2 commits intodevelopfrom
fix/phpstan-errors-on-php8-3-and-above
Jun 9, 2025
Merged

Fix PHPStan errors on PHP 8.3 and above#3414
acicovic merged 2 commits intodevelopfrom
fix/phpstan-errors-on-php8-3-and-above

Conversation

@acicovic
Copy link
Collaborator

@acicovic acicovic commented Jun 4, 2025

Description

@alecgeatches had reported that PHPStan was returning errors on PHP 8.3 and above, similar to:

Out of 39 possible constant types, only 1 - 2.5 % actually have it. Add more  
         constant types to get over 99 %

Turns out the root of the issue is the introduction of typed constants in PHP 8.3. Since we need to stick to older PHP versions, I used the constant_type setting to neutralize the errors.

Motivation and context

Fix our commit workflow from breaking on PHP8.3+.

How has this been tested?

Tested on PHP 8.3/8.4 with and without the fix.

Summary by CodeRabbit

  • Chores
    • Updated configuration comments to clarify PHP version requirements for typed properties and constants. No functional changes made.

@acicovic acicovic added this to the 3.19.4 milestone Jun 4, 2025
@acicovic acicovic self-assigned this Jun 4, 2025
@acicovic acicovic added the Maintenance & Fixes Ticket/PR related to codebase maintenance tasks label Jun 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 4, 2025

📝 Walkthrough

Walkthrough

The PHPStan configuration file was updated to add a new entry for constant_type with a value of 0. Comments were expanded to clarify PHP version requirements for typed properties and typed constants, including relevant URLs. No changes were made to code or exported/public entities.

Changes

File Change Summary
phpstan.neon Added constant_type: 0, updated comments for PHP version requirements, and added reference URLs.

Suggested reviewers

  • vaurdan

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14dd609 and ffff595.

📒 Files selected for processing (1)
  • phpstan.neon (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: E2E against WordPress latest
🔇 Additional comments (2)
phpstan.neon (2)

18-18: Approve: Document and disable typed property coverage
The inline comment clearly explains the PHP 7.4 requirement and the rationale for setting property_type: 0.


19-19: Approve: Add constant_type threshold for typed constants
The new constant_type: 0 entry with a link to PHP 8.3 documentation is accurate and preserves backward compatibility.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@acicovic acicovic marked this pull request as ready for review June 4, 2025 06:41
@acicovic acicovic requested a review from a team as a code owner June 4, 2025 06:41
Copy link
Contributor

@alecgeatches alecgeatches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring out the configuration change we needed!

@acicovic acicovic merged commit 2268223 into develop Jun 9, 2025
41 checks passed
@acicovic acicovic deleted the fix/phpstan-errors-on-php8-3-and-above branch June 9, 2025 07:39
github-actions bot added a commit that referenced this pull request Jun 9, 2025
@acicovic acicovic modified the milestones: 3.19.4, 3.20.0 Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance & Fixes Ticket/PR related to codebase maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants