Add phpMyAdmin to wp-env environment#3420
Conversation
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to configuration settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.wp-env.json (1)
5-9: Document phpMyAdmin setup in the project docs.
Now that phpMyAdmin is exposed on port 9000, the README or CONTRIBUTING guide should include instructions on how to access and use it.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.wp-env.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: E2E against WordPress latest
- GitHub Check: build
🔇 Additional comments (3)
.wp-env.json (3)
4-4: Ensure valid JSON syntax with trailing comma.
Adding the comma after thepluginsarray enables the newenvkey without syntax errors.
5-9: Approve phpMyAdmin environment configuration.
This block correctly defines adevelopmentenv withphpmyadminPort: 9000, matching the intended setup for local database access.
5-9:Details
❓ Verification inconclusive
Verify support in the installed wp-env version.
Confirm that your@wordpress/envversion recognizesphpmyadminPortby running:and checking the changelog for phpMyAdmin support.
🏁 Script executed:
npm list @wordpress/envLength of output: 75
To confirm whether
@wordpress/envis installed locally or globally and what version (if any) is in use, let’s check both global installs and your project’s package.json:
🏁 Script executed:
#!/usr/bin/env bash # Check local install/version npm ls @wordpress/env --depth=0 || echo "✓ @wordpress/env not found locally" # Check global install/version npm ls -g @wordpress/env --depth=0 || echo "✓ @wordpress/env not found globally" # See if it’s declared in your package.json grep -R "\"@wordpress/env\"" -n package.json || echo "✓ @wordpress/env not declared in package.json"Length of output: 388
Confirm phpMyAdmin port support in @wordpress/env
It looks like no local or global install was detected (but your package.json pins@wordpress/envto^10.24.0). Please ensure you’ve installed dependencies and verify the actual version in use:npm install npm list @wordpress/env --depth=0Then check the changelog to confirm that your installed version (or a later one) added support for the
phpmyadminPortoption:
https://github.com/WordPress/gutenberg/blob/trunk/packages/env/CHANGELOG.md#changelog
alecgeatches
left a comment
alecgeatches
left a comment
There was a problem hiding this comment.
Cool wp-env feature! Confirmed this worked locally.
2 participants
Description
With this PR, we're adding a running phpMyAdmin instance to our wp-env environment.
Motivation and context
How has this been tested?
npm run wp-env start.phpMyAdmin started at http://localhost:9000should appear.Summary by CodeRabbit