Skip to content

Commit 4dd7fbf

Browse files
authored
Guarantee logger exists (#3769)
The IDE was complaining that syntactically, `logger` might not exist. Satisfy the IDE. While here, move to a single `.info()` call, and update to f-string syntax. # Changed Behaviour A slight log format modification for the beginning of this script to facilitate a single log call. ## Type of change - Code maintenance/cleanup
1 parent 4ba0382 commit 4dd7fbf

File tree

1 file changed

+29
-27
lines changed

1 file changed

+29
-27
lines changed

parsl/executors/high_throughput/process_worker_pool.py

Lines changed: 29 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -939,34 +939,36 @@ def strategyorlist(s: str):
939939

940940
os.makedirs(os.path.join(args.logdir, "block-{}".format(args.block_id), args.uid), exist_ok=True)
941941

942+
logger = start_file_logger(
943+
f'{args.logdir}/block-{args.block_id}/{args.uid}/manager.log',
944+
0,
945+
level=logging.DEBUG if args.debug is True else logging.INFO
946+
)
947+
logger.info(
948+
f"\n Python version: {sys.version}"
949+
f" Debug logging: {args.debug}"
950+
f" Certificates dir: {args.cert_dir}"
951+
f" Log dir: {args.logdir}"
952+
f" Manager ID: {args.uid}"
953+
f" Block ID: {args.block_id}"
954+
f" cores_per_worker: {args.cores_per_worker}"
955+
f" mem_per_worker: {args.mem_per_worker}"
956+
f" task_port: {args.task_port}"
957+
f" result_port: {args.result_port}"
958+
f" addresses: {args.addresses}"
959+
f" max_workers_per_node: {args.max_workers_per_node}"
960+
f" poll_period: {args.poll}"
961+
f" address_probe_timeout: {args.address_probe_timeout}"
962+
f" Prefetch capacity: {args.prefetch_capacity}"
963+
f" Heartbeat threshold: {args.hb_threshold}"
964+
f" Heartbeat period: {args.hb_period}"
965+
f" Drain period: {args.drain_period}"
966+
f" CPU affinity: {args.cpu_affinity}"
967+
f" Accelerators: {' '.join(args.available_accelerators)}"
968+
f" enable_mpi_mode: {args.enable_mpi_mode}"
969+
f" mpi_launcher: {args.mpi_launcher}"
970+
)
942971
try:
943-
logger = start_file_logger('{}/block-{}/{}/manager.log'.format(args.logdir, args.block_id, args.uid),
944-
0,
945-
level=logging.DEBUG if args.debug is True else logging.INFO)
946-
947-
logger.info("Python version: {}".format(sys.version))
948-
logger.info("Debug logging: {}".format(args.debug))
949-
logger.info("Certificates dir: {}".format(args.cert_dir))
950-
logger.info("Log dir: {}".format(args.logdir))
951-
logger.info("Manager ID: {}".format(args.uid))
952-
logger.info("Block ID: {}".format(args.block_id))
953-
logger.info("cores_per_worker: {}".format(args.cores_per_worker))
954-
logger.info("mem_per_worker: {}".format(args.mem_per_worker))
955-
logger.info("task_port: {}".format(args.task_port))
956-
logger.info("result_port: {}".format(args.result_port))
957-
logger.info("addresses: {}".format(args.addresses))
958-
logger.info("max_workers_per_node: {}".format(args.max_workers_per_node))
959-
logger.info("poll_period: {}".format(args.poll))
960-
logger.info("address_probe_timeout: {}".format(args.address_probe_timeout))
961-
logger.info("Prefetch capacity: {}".format(args.prefetch_capacity))
962-
logger.info("Heartbeat threshold: {}".format(args.hb_threshold))
963-
logger.info("Heartbeat period: {}".format(args.hb_period))
964-
logger.info("Drain period: {}".format(args.drain_period))
965-
logger.info("CPU affinity: {}".format(args.cpu_affinity))
966-
logger.info("Accelerators: {}".format(" ".join(args.available_accelerators)))
967-
logger.info("enable_mpi_mode: {}".format(args.enable_mpi_mode))
968-
logger.info("mpi_launcher: {}".format(args.mpi_launcher))
969-
970972
manager = Manager(task_port=args.task_port,
971973
result_port=args.result_port,
972974
addresses=args.addresses,

0 commit comments

Comments
 (0)