Fix bug in MPITaskScheduler where tasks with identical priorities fail with TypeError
#3794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the task: dict element. * Added new test to confirm that tasks with identical priorities do not raise TypeErrors.
benclifford
reviewed
Mar 10, 2025
|
|
||
|
|
||
| @pytest.mark.local | ||
| def test_hashable_backlog_queue(): |
There was a problem hiding this comment.
if this is a regression test, I would expect it to fail, but it doesn't with master 07a4efb on my laptop
There was a problem hiding this comment.
my bad, it does fail on master! (I didn't copy it across branches properly)
There was a problem hiding this comment.
I was surprised. It definitely fails for me! Happy we got this sorted :)
benclifford
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
MPITaskScheduleruses Python's PriorityQueue to prioritize tasks based on the number of nodes requested.When items with identical priorities are are submitted to the PriorityQueue, they attempt to sort based on the task dict which fails with TypeError unhashable type: dict. This PR adds a new
PrioritizedTaskdataclass that sets the task element tofield(compare=False).I'm splitting changes in #3783 to keep the PR concise. This is split 1 of 3.
Changed Behaviour
Fixes the bug described above.
Type of change
Choose which options apply, and delete the ones which do not apply.