Replace SizedQueue use in monitoring with regular Queue #3944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PR #3937, no .qsize() has been used in monitoring. This leaves MacSafeQueue, the Mac implementation of SizedQueue, unused. It will be removed in a subsequent PR.
khk-globus
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #3937, no .qsize() has been used in monitoring.
This leaves MacSafeQueue, the Mac implementation of SizedQueue, unused. It will be removed in a subsequent PR. See PR #3932 for over-arching work
Changed Behaviour
Monitoring should now work on Mac.
Fixes
Fixes #3856 - hopefully. @d33bs has tested an approximately-equal change in #3932 on Mac, but that is not an auto-tested platform.
Type of change