Msp 2506

.github/workflows/publishonly.yml

@@ -0,0 +1,24 @@
+name: PublishOnly
+
+on:
+  workflow_dispatch:
+    inputs:
+      imageToPublish:
+        type: string
+        required: true
+        description: 'Already built docker image to publish to docker hub'
+
+  publish-docker-image:
+    name: Publish docker image
+    runs-on: ubuntu-latest
+    steps:
+      - name: Login to docker Hub
+        id: login
+        uses: docker/[email protected]
+        with:
+          username: ${{ secrets.DOCKERHUB_USER }}
+          password: ${{ secrets.DOCKERHUB_PASSWORD }}
+      - name: Publish to docker Hub
+        if: steps.login.outcome == 'success'
+        run: |
+          docker push docker.io/prebid/prebid-server:${{ inputs.imageToPublish }}

.github/workflows/scripts/codepath-notification

@@ -17,3 +17,5 @@ pubmatic: [email protected]
 openx: [email protected]
 adapters/ix|imp_ix|ix.json|ix.yaml: [email protected]
 medianet: [email protected]
+gumgum: [email protected]
+kargo: [email protected]

README.md

@@ -92,6 +92,14 @@ An option for developing Prebid Server in a reproducible environment isolated fr
 
 Prebid Server is not currently intended to be imported by other projects. Go Modules is used to manage dependencies, which also makes it possible to import Prebid Server packages. This is not supported. We offer no guarantees regarding the stability of packages and do not adhere to semantic versioning guidelines.
 
+## Swapping Global Dependencies
+
+Logger is a global side-effectful dependency that sometimes needs to be swapped to modify the behavior.  
+The `Logger` package contains an interface definition for unstructured logging with built-in `glog` implementation.
+The interface provides standard logging methods: `Debug`, `Info`, `Warn`, `Error`, and `Fatal`.
+The `glog` implementation is based on `github.com/golang/glog` package and serves as the concrete implementation for the logging interface.
+By default, the package uses the `glog` logger implementation.
+
 ## Contributing
 > [!IMPORTANT]
 > All contributions must follow the [Prebid Code of Conduct](https://prebid.org/code-of-conduct/) and the [Prebid Module Rules](https://docs.prebid.org/dev-docs/module-rules.html).

adapters/33across/33across.go

@@ -256,13 +256,7 @@ func validateVideoParams(video *openrtb2.Video, prod string) (*openrtb2.Video, e
 		}
 	}
 
-	if videoCopy.Placement == 0 {
-		videoCopy.Placement = 2
-	}
-
 	if prod == "instream" {
-		videoCopy.Placement = 1
-
 		if videoCopy.StartDelay == nil {
 			videoCopy.StartDelay = adcom1.StartDelay.Ptr(0)
 		}

adapters/33across/33acrosstest/exemplary/bidresponse-defaults.json

@@ -5,10 +5,10 @@
       {
         "id": "test-imp-id",
         "video": {
-          "w": 728, 
+          "w": 728,
           "h": 90,
           "protocols": [2],
-          "placement": 1,
+          "plcmt": 1,
           "startdelay": -2,
           "playbackmethod": [2],
           "mimes": ["foo", "bar"]
@@ -44,10 +44,10 @@
             {
               "id":"test-imp-id",
               "video": {
-                "w": 728, 
+                "w": 728,
                 "h": 90,
                 "protocols": [2],
-                "placement": 1,
+                "plcmt": 1,
                 "startdelay": -2,
                 "playbackmethod": [2],
                 "mimes": ["foo", "bar"]

adapters/33across/33acrosstest/exemplary/instream-video-defaults.json

@@ -5,7 +5,7 @@
       {
         "id": "test-imp-id",
         "video": {
-          "w": 728, 
+          "w": 728,
           "h": 90,
           "protocols": [2],
           "playbackmethod": [2],
@@ -42,10 +42,9 @@
             {
               "id":"test-imp-id",
               "video": {
-                "w": 728, 
+                "w": 728,
                 "h": 90,
                 "protocols": [2],
-                "placement": 1,
                 "startdelay": 0,
                 "playbackmethod": [2],
                 "mimes": ["foo", "bar"]

adapters/33across/33acrosstest/exemplary/multi-format.json

@@ -8,7 +8,7 @@
           "format": [{"w": 728, "h": 90}]
         },
         "video": {
-          "w": 728, 
+          "w": 728,
           "h": 90,
           "protocols": [2],
           "playbackmethod": [2],
@@ -48,10 +48,9 @@
                 "format": [{"w": 728, "h": 90}]
               },
               "video": {
-                "w": 728, 
+                "w": 728,
                 "h": 90,
                 "protocols": [2],
-                "placement": 2,
                 "playbackmethod": [2],
                 "mimes": ["foo", "bar"]
               },

adapters/33across/33acrosstest/exemplary/outstream-video-defaults.json

@@ -5,7 +5,7 @@
       {
         "id": "test-imp-id",
         "video": {
-          "w": 728, 
+          "w": 728,
           "h": 90,
           "protocols": [2],
           "playbackmethod": [2],
@@ -42,10 +42,9 @@
             {
               "id":"test-imp-id",
               "video": {
-                "w": 728, 
+                "w": 728,
                 "h": 90,
                 "protocols": [2],
-                "placement": 2,
                 "playbackmethod": [2],
                 "mimes": ["foo", "bar"]
               },

adapters/33across/33acrosstest/exemplary/site-video.json

@@ -5,10 +5,10 @@
       {
         "id": "test-imp-id",
         "video": {
-          "w": 728, 
+          "w": 728,
           "h": 90,
           "protocols": [2],
-          "placement": 1,
+          "plcmt": 1,
           "startdelay": -2,
           "playbackmethod": [2],
           "mimes": ["foo", "bar"]
@@ -44,10 +44,10 @@
             {
               "id":"test-imp-id",
               "video": {
-                "w": 728, 
+                "w": 728,
                 "h": 90,
                 "protocols": [2],
-                "placement": 1,
+                "plcmt": 1,
                 "startdelay": -2,
                 "playbackmethod": [2],
                 "mimes": ["foo", "bar"]

adapters/33across/params_test.go

@@ -40,15 +40,19 @@ func TestInvalidParams(t *testing.T) {
 }
 
 var validParams = []string{
+	`{"productId": "inview", "zoneId": "zone1"}`,
+	`{"productId": "siab", "zoneId": "fakezoneid2"}`,
+	`{"productId": "inview", "zoneId": "zone1", "siteId": "foo.ba"}`,
 	`{"productId": "inview", "siteId": "fakesiteid1"}`,
-	`{"productId": "siab", "siteId": "fakesiteid2"}`,
-	`{"productId": "inview", "siteId": "foo.ba", "zoneId": "zone1"}`,
 }
 
 var invalidParams = []string{
 	`{"productId": "inview"}`,
+	`{"zoneId": "fakezoneid2"}`,
 	`{"siteId": "fakesiteid2"}`,
+	`{"productId": 123, "zoneId": "fakesiteid2"}`,
 	`{"productId": 123, "siteId": "fakesiteid2"}`,
+	`{"productId": "siab", "zoneId": 123}`,
 	`{"productId": "siab", "siteId": 123}`,
-	`{"productId": "siab", "siteId": "fakesiteid2", "zoneId": 123}`,
+	`{"productId": "siab", "zoneId": 123, "siteId": "fakesiteid2"}`,
 }

adapters/adagio/adagio.go

@@ -2,7 +2,6 @@ package adagio
 
 import (
 	"encoding/json"
-	"errors"
 	"fmt"
 	"net/http"
 
@@ -64,7 +63,7 @@ func (a *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest
 	}
 
 	if len(bidResponse.SeatBid) == 0 {
-		return nil, []error{errors.New("empty seatbid array")}
+		return nil, []error{&errortypes.BadServerResponse{Message: "empty seatbid array"}}
 	}
 
 	var errs []error
@@ -102,7 +101,6 @@ func (a *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest
 				Bid:      &bid,
 				BidMeta:  meta,
 				BidVideo: video,
-				Seat:     openrtb_ext.BidderName(seatBid.Seat),
 				BidType:  bidType,
 			}
 			bidderResponse.Bids = append(bidderResponse.Bids, typedBid)

adapters/adagio/adagiotest/exemplary/banner-app.json

@@ -181,7 +181,6 @@
             "h": 50,
             "mtype": 1
           },
-          "seat": "adagio",
           "type": "banner"
         }
       ]