Skip to content

Learnings Hardcode Banner Size For Testing #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zwl-williamzha wants to merge 1 commit into from
Closed

Learnings Hardcode Banner Size For Testing #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions adapters/thetradedesk/thetradedesk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,25 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E

if imp.Banner != nil {
if len(imp.Banner.Format) > 0 {
firstFormat := imp.Banner.Format[0]
bannerCopy := *imp.Banner
bannerCopy.H = &firstFormat.H
bannerCopy.W = &firstFormat.W
imp.Banner = &bannerCopy

if supplySourceId == "directtqmrw45y" {
bannerCopy := *imp.Banner
bannerCopy.Format = []openrtb2.Format{
{
H: 480,
W: 320,
},
}
firstFormat := bannerCopy.Format[0]
bannerCopy.H = &firstFormat.H
bannerCopy.W = &firstFormat.W
imp.Banner = &bannerCopy
} else {
firstFormat := imp.Banner.Format[0]
bannerCopy := *imp.Banner
bannerCopy.H = &firstFormat.H
bannerCopy.W = &firstFormat.W
imp.Banner = &bannerCopy
}
Copy link
Author

@zwl-williamzha zwl-williamzha Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local Testing: Screenshot 2025-06-25 at 11 32 51 AM

Context: Screenshot 2025-06-25 at 11 33 35 AM

Copy link
Collaborator

@shunj-nb shunj-nb Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this logic to hook_bidder_request?

}
}

Expand Down
Loading