Skip to content

[Spike] Use 9.2.4-alpha.1 #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielmarbach wants to merge 2 commits into from
Closed

[Spike] Use 9.2.4-alpha.1 #2689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e5320
Use 9.2.4-alpha.1
danielmarbach Jan 10, 2025
79eebe9
Make things compile
danielmarbach Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/NServiceBus.Transport.SQS.AcceptanceTests/ConfigureEndpointSqsTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ public ConfigureEndpointSqsTransport(bool supportsPublishSubscribe = true)

public Task Configure(string endpointName, EndpointConfiguration configuration, RunSettings settings, PublisherMetadata publisherMetadata)
{
PreventInconclusiveTestsFromRunning(endpointName);

var transport = PrepareSqsTransport(supportsPublishSubscribe);
configuration.UseTransport(transport);

Expand Down Expand Up @@ -68,6 +66,7 @@ public static SqsTransport PrepareSqsTransport(bool supportsPublishSubscribe = t

static void ApplyMappingsToSupportMultipleInheritance(string endpointName, SqsTransport transportConfig)
{
// TODO: This can probably be simplified now with the publisher mapping
if (endpointName == Conventions.EndpointNamingConvention(typeof(MultiSubscribeToPolymorphicEvent.Subscriber)))
{
transportConfig.MapEvent<MultiSubscribeToPolymorphicEvent.IMyEvent, MultiSubscribeToPolymorphicEvent.MyEvent1>();
Expand Down Expand Up @@ -99,13 +98,5 @@ static void ApplyMappingsToSupportMultipleInheritance(string endpointName, SqsTr
public Task Cleanup() =>
// Queues are cleaned up once, globally, in SetupFixture.
Task.CompletedTask;

static void PreventInconclusiveTestsFromRunning(string endpointName)
{
if (endpointName == Conventions.EndpointNamingConvention(typeof(MessageDriven.Pub_from_sendonly.SendOnlyPublisher)))
{
Assert.Inconclusive("Test is not using endpoint naming conventions in hardcoded subscription storage. Should be fixed in core vNext.");
}
}
}
}
2 changes: 1 addition & 1 deletion ...ServiceBus.Transport.SQS.AcceptanceTests/NServiceBus.Transport.SQS.AcceptanceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<ItemGroup>
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.2.3" GeneratePathProperty="true" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.2.4-alpha.1" GeneratePathProperty="true" />
<PackageReference Include="NUnit" Version="4.3.2" />
<PackageReference Include="NUnit.Analyzers" Version="4.6.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
Expand Down