Open RavenDB.Client version range for broader compatibility#726
Merged
danielmarbach merged 11 commits intomasterfrom Sep 6, 2025
Merged
Open RavenDB.Client version range for broader compatibility#726danielmarbach merged 11 commits intomasterfrom
danielmarbach merged 11 commits intomasterfrom
Conversation
danielmarbach
changed the title
danielmarbach
commented
Sep 5, 2025
src/NServiceBus.Gateway.RavenDB/NServiceBus.Gateway.RavenDB.csproj
Outdated
Show resolved
Hide resolved
src/NServiceBus.Gateway.RavenDB/NServiceBus.Gateway.RavenDB.csproj
Outdated
Show resolved
Hide resolved
danielmarbach
commented
Sep 5, 2025
danielmarbach
commented
Sep 5, 2025
...way.RavenDB.Latest.AcceptanceTests/NServiceBus.Gateway.RavenDB.Latest.AcceptanceTests.csproj
Outdated
Show resolved
Hide resolved
danielmarbach
commented
Sep 5, 2025
...test.AcceptanceTests/NServiceBus.Gateway.RavenDB.ClusterWideTx.Latest.AcceptanceTests.csproj
Outdated
Show resolved
Hide resolved
Contributor
|
Changes look good to me; my only concern is whether we're adding extra load by running the same set of tests with a different version. Only one test case can be verified. |
DharmishthaVPatel
approved these changes
Sep 6, 2025
Contributor
|
LGTM - approved |
DharmishthaVPatel
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Have a latest project with renovate configured * Try latest action * Deliberately use something lower for now * Correct format * Try this * Move * Cluster wide latest * Cap upper bound * Indent * Stable action * Upgrade to latest for now --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to RavenDB backward compatibility issues on the client API surface is something they really care about.
They recommended us to target the LTS version as a minimum version using the
Minimum version, inclusivesyntax in the nuget ranges.To play slightly extra safe, we are capping the range to currently supported LTS and STS.
Should one day a version be released that is incompatible with the persister, we can release a patch that locks into the last known configuration and release another minor version bringing in the version that has breaking changes as the minimum required version.
Customers using the persistence that do not take an explicit dependency on RavenDB.Client will get the minimum required LTS version by default. This seems to be a reasonable tradeoff between allowing a broader range of client versions and unlocking people leveraging features of newer server versions that remain backward compatible.