Introduce provider to support overriding the mongo client using dependency injection #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afprtclr
approved these changes
Aug 19, 2025
danielmarbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a provider concept that allows resolving the mongo client from the container. Similar functionality is already available in DynamoDB, CosmoDB, and Azure Table.
Unfortunately the names haven't been kept consistent. In the past we used quite a few
I{VERB}type of interfaces, which has been criticized publicly, and some attempts have been made to no longer use names like that. CosmosDB and AzureTable, if I'm not mistaken, had those names already in there, while DynamoDB persistence was created later following the "modern" nomenclature.This PR also makes sure that installers only run when they actually should (in case their corresponding feature is activated).