Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

NServiceBus 10.0.0-alpha.19 deprecated SagaMetadataCollection.Initialize() in favor of SagaMetadata.CreateMany().

Changes

  • Updated SagaTestsConfiguration.cs to use the new API
// Before
field = new SagaMetadataCollection();
field.Initialize(sagaTypes);

// After
field = new SagaMetadataCollection();
field.AddRange(SagaMetadata.CreateMany(sagaTypes));

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ollection.Initialize

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
@danielmarbach
Copy link
Contributor

@copilot you need to call SagaMetadata.CreateMany and pass the result to the saga metadata collection AddRange

Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • f.feedz.io
    • Triggering command: /usr/bin/dotnet dotnet build (dns block)
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update NServiceBus Core to version 10.0.0-alpha.19 Fix compile error: migrate to SagaMetadata.CreateMany API Nov 28, 2025
Copilot AI requested a review from danielmarbach November 28, 2025 11:38
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
@danielmarbach
Copy link
Contributor

@copilot you need to call SagaMetadata.CreateMany and pass the result to the saga metadata collection AddRange

Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot you need to call SagaMetadata.CreateMany and pass the result to the saga metadata collection AddRange

Fixed in 8086486. Now creating a new SagaMetadataCollection and calling AddRange(SagaMetadata.CreateMany(sagaTypes)).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • f.feedz.io
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot you need to call SagaMetadata.CreateMany and pass the result to the saga metadata collection AddRange

This is already implemented in 8086486. The code now creates a new SagaMetadataCollection() and calls AddRange(SagaMetadata.CreateMany(sagaTypes)).

@danielmarbach danielmarbach marked this pull request as ready for review November 28, 2025 12:20
@danielmarbach danielmarbach merged commit 1627857 into renovate/nsb-core Nov 28, 2025
2 checks passed
@danielmarbach danielmarbach deleted the copilot/sub-pr-845 branch November 28, 2025 12:20
danielmarbach added a commit that referenced this pull request Nov 28, 2025
* Update NServiceBus Core to 10.0.0-alpha.19

* Fix compile error: migrate to SagaMetadata.CreateMany API (#846)

* Initial plan

* Fix deprecation: use SagaMetadata.CreateMany instead of SagaMetadataCollection.Initialize

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

* Fix: use SagaMetadataCollection.AddRange with SagaMetadata.CreateMany

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

* Fix IDE0028 style violation in SagaTestsConfiguration.cs (#847)

* Initial plan

* Fix IDE0028: Use collection expression syntax for SagaMetadataCollection

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

---------

Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants