Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

NServiceBus Core 10.0.0-alpha.19 update introduced a code change that violated the project's strict IDE0028 style rules, causing build failures on both Linux and Windows CI.

Changes

  • Replaced verbose collection initialization pattern with collection expression syntax in SagaTestsConfiguration.cs
// Before
field = new SagaMetadataCollection();
field.AddRange(SagaMetadata.CreateMany(sagaTypes));

// After
field = [.. SagaMetadata.CreateMany(sagaTypes)];

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • f.feedz.io
    • Triggering command: /usr/bin/dotnet dotnet build (dns block)
    • Triggering command: /usr/bin/dotnet dotnet build --no-restore (dns block)
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update NServiceBus Core to 10.0.0-alpha.19 Fix IDE0028 style violation in SagaTestsConfiguration.cs Nov 28, 2025
Copilot AI requested a review from danielmarbach November 28, 2025 12:54
@danielmarbach danielmarbach marked this pull request as ready for review November 28, 2025 12:56
@danielmarbach danielmarbach merged commit 24f4720 into renovate/nsb-core Nov 28, 2025
7 checks passed
@danielmarbach danielmarbach deleted the copilot/sub-pr-845 branch November 28, 2025 12:57
danielmarbach added a commit that referenced this pull request Nov 28, 2025
* Update NServiceBus Core to 10.0.0-alpha.19

* Fix compile error: migrate to SagaMetadata.CreateMany API (#846)

* Initial plan

* Fix deprecation: use SagaMetadata.CreateMany instead of SagaMetadataCollection.Initialize

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

* Fix: use SagaMetadataCollection.AddRange with SagaMetadata.CreateMany

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

* Fix IDE0028 style violation in SagaTestsConfiguration.cs (#847)

* Initial plan

* Fix IDE0028: Use collection expression syntax for SagaMetadataCollection

Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>

---------

Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants