Analyzer: Error when Feature Defaults are used to enable other features #7476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a Roslyn analyzer and code fix to detect and correct improper feature enablement patterns in NServiceBus features.
Problem:
Using
EnableFeature<TFeature>()inside theDefaultsmethod violates NServiceBus best practices. Dependent features should be enabled via the protectedEnable<TFeature>()method in the constructor instead.Changes:
FeatureDefaultsEnableFeatureAnalyzer(NSB0019) to detectEnableFeature<TFeature>()calls withinDefaultslambdasFeatureDefaultsEnableFeatureFixerto automatically move these calls to the constructor usingEnable<TFeature>()Example:
Scoped out:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.