Merge saga diagnostics now that they're both error #7579
Merged
+39
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
approved these changes
Jan 7, 2026
Contributor
danielmarbach
left a comment
danielmarbach
left a comment
There was a problem hiding this comment.
I'm good with it. I would vote though to adjust NSB0004 message because multiple is not relevant. The code must be rewritten regardless. Thoughts?
The saga mapping contains multiple .ToSaga(…) expressions which must be rewritten using mapper.MapSaga(…).ToMessage(…) syntax. Use the code fix to transition to the new syntax.
Pre approving
DavidBoike
merged commit e0aa9af
into
copilot/update-saga-diagnostics-error
4 checks passed
DavidBoike
added a commit
that referenced
this pull request
Jan 7, 2026
…7576) * Initial plan * Change NSB0018 saga diagnostic from Info to Error Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com> * Change NSB0004 saga diagnostic from Warning to Error Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com> * Merge saga diagnostics now that they're both error (#7579) * Merge diagnostics * Adjust message --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com> Co-authored-by: David Boike <david.boike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a test to ensure that a saga not found handler will not trigger a diagnostic, as it is a new API on SagaMapper. There was already a test added for custom saga finders.