Acceptance test Done statement improvements #7588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
done_conditions
branch
from
6cf69f4 to
8ed3bde
Compare
danielmarbach
force-pushed
the
done_conditions
branch
from
c3d299d to
fa381d3
Compare
Contributor
Author
|
Given this PR is not really necessary for v10 I marked it as a draft |
DavidBoike
approved these changes
Jan 13, 2026
andreasohlund
approved these changes
Jan 14, 2026
| public Task Handle(MyMessage message, IMessageHandlerContext context) | ||
| { | ||
| Interlocked.Increment(ref testContext.TotalHandledMessages); | ||
| var count = Interlocked.Increment(ref testContext.TotalHandledMessages); |
Member
There was a problem hiding this comment.
Is there a reason for declaring the variable?
Contributor
Author
There was a problem hiding this comment.
It could also be inlined
danielmarbach
commented
Jan 15, 2026
src/NServiceBus.AcceptanceTests/Core/OpenTelemetry/When_incoming_message_handled.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow through on #7556
Related to
#7563