-
Notifications
You must be signed in to change notification settings - Fork 0
Increasing metrics days collected for both AzureServiceBus and AWS SQS #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| foreach (var metricValue in metricValues) | ||
| { | ||
| currentDate = DateOnly.FromDateTime(metricValue.TimeStamp.UtcDateTime); | ||
| data[currentDate] = new DailyThroughput { MessageCount = (long)(metricValue.Total ?? 0), DateUTC = currentDate }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we distinguish your initialized "0" above from the metrics "0"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to distinguish whether the zero comes from the default or is set later on?
There is no reason to distinguish those.
The reason we need to do (metricValue.Total ?? 0) is because metricValue.Total can return a null, that is all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what circumstances lead to a null?
|
@saratry @aleksandr-samila, I have pushed an update to deal with the start/end dates. Also, I realise that if a customer decommissions an endpoint and deletes the queue, the metrics will no longer be available for the deleted queue. Hopefully, this is not something that happens a lot! |
We are increasing AzureServiceBus to collect 90 days of data and SQS to collect 365 days.
This is related to https://github.com/Particular/CustomerSuccess/issues/4092