File tree Expand file tree Collapse file tree 2 files changed +10
-10
lines changed
ServiceControl.Audit.Persistence.RavenDB
ServiceControl.Persistence.RavenDB Expand file tree Collapse file tree 2 files changed +10
-10
lines changed Original file line number Diff line number Diff line change @@ -8,11 +8,11 @@ namespace ServiceControl.Audit.Persistence.RavenDB;
88
99class MemoryInformationRetriever ( DatabaseConfiguration databaseConfiguration )
1010{
11- // What does a connection string look like? Is it only a URI or could it contain other stuff?
12- // The ?? operator is needed because ServerUrl is populated when running embedded and connection
13- // string when running in external mode. However, the tricky part is that when tests are run they
14- // behave like if it was external mode. If the connection string contain always only the server
15- // URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
11+ // Connection string is composed of the server URL. The ?? operator is needed because ServerUrl
12+ // is populated when running embedded and connection string when running in external mode.
13+ // However, the tricky part is that when tests are run they behave like if it was external mode.
14+ // ServerUrl is always populated by the persister settings, hence the code first checks for the
15+ // presence of a connection string, and if null, falls back to ServerUrl
1616 readonly HttpClient client = new ( ) { BaseAddress = new Uri ( databaseConfiguration . ServerConfiguration . ConnectionString ?? databaseConfiguration . ServerConfiguration . ServerUrl ) } ;
1717
1818 record ResponseDto
Original file line number Diff line number Diff line change @@ -8,11 +8,11 @@ namespace ServiceControl.Persistence.RavenDB;
88
99class MemoryInformationRetriever ( RavenPersisterSettings persisterSettings )
1010{
11- // What does a connection string look like? Is it only a URI or could it contain other stuff?
12- // The ?? operator is needed because ServerUrl is populated when running embedded and connection
13- // string when running in external mode. However, the tricky part is that when tests are run they
14- // behave like if it was external mode. If the connection string contain always only the server
15- // URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
11+ // Connection string is composed of the server URL. The ?? operator is needed because ServerUrl
12+ // is populated when running embedded and connection string when running in external mode.
13+ // However, the tricky part is that when tests are run they behave like if it was external mode.
14+ // ServerUrl is always populated by the persister settings, hence the code first checks for the
15+ // presence of a connection string, and if null, falls back to ServerUrl
1616 readonly HttpClient client = new ( ) { BaseAddress = new Uri ( persisterSettings . ConnectionString ?? persisterSettings . ServerUrl ) } ;
1717
1818 record ResponseDto
You can’t perform that action at this time.
0 commit comments