Add test for non zero return codes

Author: andreasohlund

src/ServiceControlInstaller.Engine.UnitTests/Setup/SetupInstanceTests.cs

@@ -17,4 +17,12 @@ public void Should_capture_and_rethrow_failures()
 
         Assert.That(ex.Message, Does.Contain("Fake exception"));
     }
+
+    [Test]
+    public void Should_capture_and_rethrow_non_zero_exit_codes()
+    {
+        var ex = Assert.Throws<Exception>(() => InstanceSetup.Run(TestContext.CurrentContext.WorkDirectory, "SetupProcessFake.exe", "test", "non-zero-exit-code"));
+
+        Assert.That(ex.Message, Does.Contain("returned a non-zero exit code: 3"));
+    }
 }

src/ServiceControlInstaller.Engine/Setup/InstanceSetup.cs

@@ -60,7 +60,7 @@ internal static void Run(string installPath, string exeName, string instanceName
 
         if (p.ExitCode != 0)
         {
-            throw new Exception($"{exeName} threw an error when performing setup. This typically indicates a configuration error. The error output from {exeName} was:\r\n {error}");
+            throw new Exception($"{exeName} returned a non-zero exit code: {p.ExitCode}. This typically indicates a configuration error. The error output was:\r\n {error}");
         }
     }
 }

src/SetupProcessFake/Program.cs

@@ -1,4 +1,11 @@
 if (args.Any(a => a == "fail"))
 {
     throw new Exception("Fake exception");
-}
+}
+
+if (args.Any(a => a == "non-zero-exit-code"))
+{
+    return 3;
+}
+
+return 0;