Skip to content

Commit 974a96a

Browse files
committed
Ported disposing of RavenDB during stop to primary instance
1 parent 9c0bd7a commit 974a96a

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

src/ServiceControl.Persistence.RavenDB/IRavenPersistenceLifecycle.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@ namespace ServiceControl.Persistence.RavenDB
88
interface IRavenPersistenceLifecycle
99
{
1010
Task Initialize(CancellationToken cancellationToken = default);
11+
Task Stop(CancellationToken cancellationToken);
1112
}
1213
}

src/ServiceControl.Persistence.RavenDB/RavenEmbeddedPersistenceLifecycle.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,14 @@ public async Task Initialize(CancellationToken cancellationToken)
6969
}
7070
}
7171

72+
public async Task Stop(CancellationToken cancellationToken)
73+
{
74+
if (database != null)
75+
{
76+
await database.Stop(cancellationToken);
77+
}
78+
}
79+
7280
public void Dispose()
7381
{
7482
documentStore?.Dispose();

src/ServiceControl.Persistence.RavenDB/RavenExternalPersistenceLifecycle.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ public async Task Initialize(CancellationToken cancellationToken)
5959
}
6060
}
6161

62+
public Task Stop(CancellationToken cancellationToken) => Task.CompletedTask;
63+
6264
public void Dispose() => documentStore?.Dispose();
6365

6466
IDocumentStore? documentStore;

src/ServiceControl.Persistence.RavenDB/RavenPersistenceLifecycleHostedService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ class RavenPersistenceLifecycleHostedService(IRavenPersistenceLifecycle persiste
1010
{
1111
public Task StartAsync(CancellationToken cancellationToken) => persistenceLifecycle.Initialize(cancellationToken);
1212

13-
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
13+
public Task StopAsync(CancellationToken cancellationToken) => persistenceLifecycle.Stop(cancellationToken);
1414
}
1515
}

0 commit comments

Comments
 (0)