Metrics logging to separate log file and forcing to use invariant culture for logging metrics values

Author: ramonsmits

src/ServiceControl.Infrastructure.Metrics/MetricsReporter.cs

@@ -1,6 +1,9 @@
 namespace ServiceControl.Infrastructure.Metrics
 {
     using System;
+    using System.Globalization;
+    using System.Runtime.CompilerServices;
+    using System.Text;
     using System.Threading;
     using System.Threading.Tasks;
 
@@ -49,8 +52,8 @@ void Print()
             var values = metrics.GetMeterValues();
             foreach (var metricSet in values)
             {
-                printLine(
-                    $"{metricSet.Name,-40};{metricSet.Current:F};{metricSet.Average15:F};{metricSet.Average60:F};{metricSet.Average300:F}");
+                FormattableString x = $"{metricSet.Name};{metricSet.Current:F};{metricSet.Average15:F};{metricSet.Average60:F};{metricSet.Average300:F}";
+                printLine(x.ToString(CultureInfo.InvariantCulture));
             }
         }
 

src/ServiceControl.Infrastructure/LoggingConfigurator.cs

@@ -57,11 +57,26 @@ public static void ConfigureLogging(LoggingSettings loggingSettings)
                 FinalMinLevel = LogLevel.Warn
             };
 
+
             nlogConfig.LoggingRules.Add(aspNetCoreRule);
             nlogConfig.LoggingRules.Add(httpClientRule);
 
             nlogConfig.LoggingRules.Add(new LoggingRule("*", loggingSettings.LogLevel, consoleTarget));
 
+            var csvMetricsTarget = new FileTarget
+            {
+                Name = "csvMetrics",
+                ArchiveEvery = FileArchivePeriod.Day,
+                FileName = Path.Combine(loggingSettings.LogPath, "metrics/${shortdate}.csv"),
+                ArchiveFileName = Path.Combine(loggingSettings.LogPath, "metrics/logfile.{#}.csv"),
+                ArchiveNumbering = ArchiveNumberingMode.DateAndSequence,
+                Layout = new SimpleLayout("${longdate};${level};${logger};${message}"),
+                MaxArchiveFiles = 14,
+                ArchiveAboveSize = 30 * megaByte,
+                CreateDirs = true
+            };
+            nlogConfig.LoggingRules.Add(new LoggingRule("Metrics", loggingSettings.LogLevel, csvMetricsTarget));
+
             if (!AppEnvironment.RunningInContainer)
             {
                 nlogConfig.LoggingRules.Add(new LoggingRule("*", loggingSettings.LogLevel, fileTarget));