Skip to content

Updated NServiceBus.AmazonSQS to 7.1.0 #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonsmits merged 5 commits into from
Nov 26, 2024
Merged

Updated NServiceBus.AmazonSQS to 7.1.0 #4641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3320171
Updated to make use new constructor to disable delayed delivery
ramonsmits Nov 25, 2024
da56659
Cleanup
ramonsmits Nov 25, 2024
98bd07a
NServiceBus.AmazonSQS 7.1.0-alpha.1
ramonsmits Nov 25, 2024
9629a3c
typo
ramonsmits Nov 25, 2024
27fa4e5
NServiceBus.AmazonSQS 7.1.0
ramonsmits Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<PackageVersion Include="NLog.Extensions.Logging" Version="5.3.14" />
<PackageVersion Include="NServiceBus" Version="9.2.3" />
<PackageVersion Include="NServiceBus.AcceptanceTesting" Version="9.2.3" />
<PackageVersion Include="NServiceBus.AmazonSQS" Version="7.0.1" />
<PackageVersion Include="NServiceBus.AmazonSQS" Version="7.1.0" />
<PackageVersion Include="NServiceBus.CustomChecks" Version="5.0.0" />
<PackageVersion Include="NServiceBus.Extensions.Hosting" Version="3.0.0" />
<PackageVersion Include="NServiceBus.Extensions.Logging" Version="3.0.0" />
Expand Down
8 changes: 3 additions & 5 deletions src/ServiceControl.Transports.SQS/SQSTransportCustomization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ protected override SqsTransport CreateTransport(TransportSettings transportSetti
snsClient = new AmazonSimpleNotificationServiceClient();
}

var transport = new SqsTransport(sqsClient, snsClient);
#pragma warning disable NSBSQSEXP0001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
var transport = new SqsTransport(sqsClient, snsClient, enableDelayedDelivery: false);
#pragma warning restore NSBSQSEXP0001

if (!string.IsNullOrEmpty(builder.QueueNamePrefix))
{
Expand Down Expand Up @@ -109,14 +111,10 @@ protected override SqsTransport CreateTransport(TransportSettings transportSetti
transport.DoNotWrapOutgoingMessages = builder.DoNotWrapOutgoingMessages;

transport.TransportTransactionMode = transport.GetSupportedTransactionModes().Contains(preferredTransactionMode) ? preferredTransactionMode : TransportTransactionMode.ReceiveOnly;
DisableDelayedDelivery(transport) = true;

return transport;
}

[UnsafeAccessor(UnsafeAccessorKind.Field, Name = "<DisableDelayedDelivery>k__BackingField")]
static extern ref bool DisableDelayedDelivery(SqsTransport transport);

static void
PromoteEnvironmentVariableFromConnectionString(string value, string environmentVariableName) =>
Environment.SetEnvironmentVariable(environmentVariableName, value, EnvironmentVariableTarget.Process);
Expand Down