Skip to content

Add header necessary for retry when messages are edited and retried #4746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmasternak merged 1 commit into from
Jan 24, 2025
Merged

Add header necessary for retry when messages are edited and retried #4746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ServiceControl/Recoverability/Editing/EditHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,14 @@ public async Task Handle(EditAndSend message, IMessageHandlerContext context)
var outgoingMessage = BuildMessage(message);
// mark the new message with a link to the original message id
outgoingMessage.Headers.Add("ServiceControl.EditOf", message.FailedMessageId);
outgoingMessage.Headers["ServiceControl.Retry.AcknowledgementQueue"] = "";
var address = ApplyRedirect(attempt.FailureDetails.AddressOfFailingEndpoint, redirects);

if (outgoingMessage.Headers.TryGetValue("ServiceControl.RetryTo", out var retryTo))
{
outgoingMessage.Headers["ServiceControl.TargetEndpointAddress"] = address;
address = retryTo;
}
await DispatchEditedMessage(outgoingMessage, address, context);
}

Expand Down