I/O Timeouts can cause error and audit ingestion to silently stop#4780
Merged
ramonsmits merged 1 commit intomasterfrom Feb 11, 2025
Merged
I/O Timeouts can cause error and audit ingestion to silently stop#4780ramonsmits merged 1 commit intomasterfrom
ramonsmits merged 1 commit intomasterfrom
Conversation
ramonsmits
force-pushed
the
hanging-ingestion
branch
from
1e56a0e to
9c249c9
Compare
src/Particular.LicensingComponent/AuditThroughput/AuditThroughputCollectorHostedService.cs
Show resolved
Hide resolved
andreasohlund
approved these changes
Feb 7, 2025
Member
Author
|
@andreasohlund Load tested this build for 12+ hours with multiple instances on this version and 6.3.0. All 6.3.0 instances eventually halted processing. |
andreasohlund
changed the title
ramonsmits
force-pushed
the
hanging-ingestion
branch
from
a0696c3 to
b779f00
Compare
This was referenced Feb 10, 2025
…ich can cause the ingestion to never used incoming context tasks and hang. - Rectored to use BackgroundService - Fix `catch (OperationCancelledException)` blocks to add `when` guards - only ignore cancellations set by caller - Overriding Start and Stop to support graceful shutdown and improve intent and readability - Ensure TrySetException is always set on exception - Logging improvements around cancellation to inform that tasks got cancelled. Important when shutting down to diagnose where teardown "hangs".
ramonsmits
force-pushed
the
hanging-ingestion
branch
from
b779f00 to
b8d5744
Compare
andreasohlund
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I/O Timeouts can cause error and audit ingestion to silently stop.
Symptoms
No error or audit messages are ingested.
Who's affected
All customers running version 5 and 6 are affected by this issue.
NOTE: Versions before 4.32.0 are not affected.
Root cause
OperationCancelledException can cause hanging ingestion, unnoticed failing tasks, and no logging of timeouts
Backported to