Skip to content

Add custom checks acceptance tests #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Feb 7, 2025
Merged

Add custom checks acceptance tests #2216

merged 33 commits into from
Feb 7, 2025

Conversation

@soujay
Copy link
Contributor

@soujay soujay commented Jan 20, 2025 •
edited
Loading

Adding some mock data and tests to Custom checks

@soujay soujay self-assigned this Jan 20, 2025
@soujay soujay changed the title Add customchecks acceptance tests js Add customchecks acceptance tests Jan 20, 2025
@soujay soujay changed the title Add customchecks acceptance tests Add custom checks acceptance tests Jan 20, 2025
cquirosj
cquirosj reviewed Jan 21, 2025
View reviewed changes
@soujay soujay force-pushed the add-customchecks-acceptance-tests-js branch from 186d513 to d52e25c Compare February 4, 2025 23:24
cquirosj
cquirosj approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@cquirosj cquirosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid first step! While I see several areas that could be refined further, this moves us in the right direction, and we can build on it in future iterations. Approving this now — great work!

@kentdr kentdr marked this pull request as ready for review February 7, 2025 18:11
soujay and others added 19 commits February 7, 2025 10:24
@soujay
Testing
1b1ad11
@soujay
raw testing of mock data Frontend custom checks
72e8863
@cquirosj @soujay
dynamic precondition function hasCustomChecks
28d7c4d
@cquirosj @soujay
No data custom checks tests
54e0a7b
@cquirosj @soujay
wip Failing custom checks tests
25c060d
@cquirosj @soujay
All custom checks are in a failed state TODOs
4d2e333
@cquirosj @soujay
precondition.hasCustomChecks params rename
b67139a
@cquirosj @soujay
WIP All custom checks are in a failed state asserts
e048aed
@soujay
Revert "WIP All custom checks are in a failed state asserts"
045f117 
This reverts commit dca2eb7.
@soujay
Revert "precondition.hasCustomChecks params rename"
b91f7c7 
This reverts commit a337eb2.
@soujay
Revert "All custom checks are in a failed state TODOs"
cd7ec35 
This reverts commit 44edfad.
@soujay
Revert "wip Failing custom checks tests"
9ec1094 
This reverts commit 300bfd1.
@soujay
Revert "No data custom checks tests"
108a218 
This reverts commit fcfd091.
@soujay
Revert "dynamic precondition function hasCustomChecks"
6b1ae92 
This reverts commit 07ade85.
@soujay
wip : add mocks for custom checks data, add test to check for "no fai…
efbb80e 
…led custom checks message" -
@soujay
add driver set up for servicecontrolwithmonitoring to fix the tests
56379a8
@soujay
refactor files and code
03a59cd
@soujay
add a template for custom check items and use it for tests
1b2b5fa
@soujay
use mockEndpointDynamic to add customchecks url by querystring
aef91cf
soujay and others added 14 commits February 7, 2025 10:25
@soujay
remove extra space
7f3a697
@soujay
added some console.log for testing
c3d833f
@soujay @cquirosj
Update src/Frontend/test/specs/customchecks/viewing-no-data.spec.ts
df1ea7d 
Co-authored-by: Christian <[email protected]>
@soujay @cquirosj
Update src/Frontend/test/specs/customchecks/viewing-no-data.spec.ts
2750668 
Co-authored-by: Christian <[email protected]>
@soujay
add test for no custom check data scenario
00a066a
@soujay
set up mock data for custom check and write tests for empty and faile…
1b9c24b 
…d custom check listing
@soujay
add no data and failing cutom checks
be1a0c3
@soujay
fix custom check pagination test
f13e57f
@soujay
generate custom check items
249bf32
@soujay
add test for custom checks to be displayed in descending order of las…
2db3427 
…t checked on the custom checks tab
@soujay
Added the following tests- When a custom check fails, the custom chec…
427e9c0 
…ks tab is auto-refreshed with the new failed custom check, A failing custom check that begins passing is auto-refreshed and removed from the list on the custom checks tab
@soujay
test for dismissing a custom check
31481fc
@soujay
add test for dismissbutton
03b862f
@soujay
refactor code
2a6c65d
@soujay soujay force-pushed the add-customchecks-acceptance-tests-js branch from 898fda9 to 2a6c65d Compare February 7, 2025 18:26
@kentdr kentdr merged commit b7ba138 into master Feb 7, 2025
4 checks passed
@kentdr kentdr deleted the add-customchecks-acceptance-tests-js branch February 7, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cquirosj cquirosj cquirosj approved these changes

@poornimanayar poornimanayar Awaiting requested review from poornimanayar

+1 more reviewer

@kentdr kentdr kentdr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soujay soujay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soujay @cquirosj @kentdr