Add displaying of usage per month #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
force-pushed
the
john/month_usage
branch
from
5787721 to
fe69b76
Compare
johnsimons
commented
Mar 7, 2025
| .sort(sortItem?.comparer); | ||
| }); | ||
| // We can remove this hidden toggle once we have new edition licenses. | ||
| const hiddenFeatureToggle = useHiddenFeature(["ArrowUp", "ArrowUp", "ArrowDown", "ArrowDown"]); |
There was a problem hiding this comment.
I have added a hidden keys combo to turn on this feature for testing purposes
johnsimons
commented
Mar 7, 2025
| }); | ||
| // We can remove this hidden toggle once we have new edition licenses. | ||
| const hiddenFeatureToggle = useHiddenFeature(["ArrowUp", "ArrowUp", "ArrowDown", "ArrowDown"]); | ||
| const showMonthly = computed(() => license.edition === "MonthlyUsage" || hiddenFeatureToggle.value); |
There was a problem hiding this comment.
The name of the "edition" needs to be updated once we decide.
johnsimons
force-pushed
the
john/month_usage
branch
from
fe69b76 to
16928dd
Compare
johnsimons
commented
Mar 7, 2025
| }; | ||
|
|
||
| const license = reactive<License>(emptyLicense); | ||
| class emptyLicense implements License { |
There was a problem hiding this comment.
I have decided to refactor this type to be a class so we can reference its data directly.
The previous implementation was not giving the correct result.
johnsimons
force-pushed
the
john/month_usage
branch
from
16928dd to
56cc0e9
Compare
mikeminutillo
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support future license models based on monthly usage.
This PR is backward-compatible, but in order to test it, you need Particular/ServiceControl#4863