Refactor message tabs views into separate components #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise attempts to use CDN
johnsimons
commented
Mar 13, 2025
| import PageHeader from "./components/PageHeader.vue"; | ||
| import "bootstrap"; | ||
| import { useServiceControlUrls } from "@/composables/serviceServiceControlUrls"; | ||
| import "highlight.js/styles/github-dark.css"; |
There was a problem hiding this comment.
This is moved to the mount.ts
johnsimons
commented
Mar 13, 2025
| import { useRouter } from "vue-router"; | ||
| import "bootstrap"; | ||
| import { monitoringUrl, serviceControlUrl, useIsMonitoringDisabled } from "@/composables/serviceServiceControlUrls"; | ||
| import "highlight.js/styles/github-dark.css"; |
johnsimons
commented
Mar 13, 2025
| ); | ||
| </script> | ||
| <template> | ||
| <div></div> |
johnsimons
commented
Mar 13, 2025
| }); | ||
| </script> | ||
| <template> | ||
| <div></div> |
johnsimons
commented
Mar 13, 2025
| <div v-if="panel === 3 && failedMessage.bodyUnavailable" class="alert alert-info">Message body unavailable.</div> | ||
| <FlowDiagram v-if="panel === 4" :conversation-id="failedMessage.conversationId" :message-id="id"></FlowDiagram> | ||
| <StackTraceView v-if="panel === 1" :message="failedMessage" /> | ||
| <BodyView v-if="panel === 2" :message="failedMessage" /> |
There was a problem hiding this comment.
moved "message body" to be 2nd tab
johnsimons
commented
Mar 13, 2025
|
|
||
| const VCodeBlock = createVCodeBlock({ | ||
| theme: "github-dark", | ||
| cssPath: "highlight.js/styles/github-dark.css", |
There was a problem hiding this comment.
This is needed, otherwise the highligh.js lib attempts to contact a CDN
johnsimons
changed the title
PhilBastian
reviewed
Mar 13, 2025
| </script> | ||
|
|
||
| <template> | ||
| <VCodeBlock :code="props.message.exception.stack_trace" lang="csharp"></VCodeBlock> |
There was a problem hiding this comment.
should this be csharp highlighted, given that it's a stack trace?
There was a problem hiding this comment.
There is no highlighter mode for stack traces, and c# did not look bad, so I went with that one.
There was a problem hiding this comment.
would plain text be better then?
PhilBastian
approved these changes
Mar 13, 2025
johnsimons
added
Type: Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the tabs views for the message to be their components