Skip to content

Change to useTemplateRef for refs #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Change to useTemplateRef for refs #2290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ interface ExtendedFailureGroupView extends FailureGroupView {
}

let pollingFaster = false;
const messageGroupList = ref();
const archiveGroups = ref<ExtendedFailureGroupView[]>([]);
const undismissedRestoreGroups = ref<ExtendedFailureGroupView[]>([]);
const loadingData = ref(true);
Expand Down Expand Up @@ -68,12 +67,12 @@ function saveDefaultGroupingClassifier(classifier: string) {
cookies.set("archived_groups_classification", classifier);
}

function classifierChanged(classifier: string) {
async function classifierChanged(classifier: string) {
saveDefaultGroupingClassifier(classifier);

selectedClassifier.value = classifier;
archiveGroups.value = [];
messageGroupList.value = loadArchivedMessageGroups(classifier);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messageGroupList was not being used as a ref nor for anything given that loadArchivedMessageGroups(classifier) returns void!

await loadArchivedMessageGroups(classifier);
}

async function getArchiveGroups(classifier: string) {
Expand Down Expand Up @@ -304,7 +303,7 @@ onMounted(async () => {

<div class="box-container">
<div class="messagegrouplist">
<div ref="messageGroupList">
<div>
<div class="row">
<div class="col-sm-12">
<no-data v-if="archiveGroups.length === 0 && !loadingData" title="message groups" message="There are currently no grouped message failures"></no-data>
Expand Down
4 changes: 2 additions & 2 deletions src/Frontend/src/components/failedmessages/FailedMessageGroups.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { onMounted, ref } from "vue";
import { onMounted, ref, useTemplateRef } from "vue";
import { licenseStatus } from "../../composables/serviceLicense";
import { connectionState } from "../../composables/serviceServiceControl";
import { useTypedFetchFromServiceControl } from "../../composables/serviceServiceControlUrls";
Expand All @@ -15,7 +15,7 @@ import getSortFunction from "@/components/getSortFunction";

const selectedClassifier = ref<string>("");
const classifiers = ref<string[]>([]);
const messageGroupList = ref<IMessageGroupList>();
const messageGroupList = useTemplateRef<IMessageGroupList>("messageGroupList");
const sortMethod = ref<SortOptions<GroupOperation>["sort"]>();

function sortGroups(sort: SortOptions<GroupOperation>) {
Expand Down
4 changes: 2 additions & 2 deletions src/Frontend/src/components/failedmessages/FailedMessages.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { onMounted, onUnmounted, ref, watch } from "vue";
import { onMounted, onUnmounted, ref, useTemplateRef, watch } from "vue";
import { licenseStatus } from "../../composables/serviceLicense";
import { connectionState } from "../../composables/serviceServiceControl";
import { useFetchFromServiceControl, usePatchToServiceControl, useTypedFetchFromServiceControl } from "../../composables/serviceServiceControlUrls";
Expand Down Expand Up @@ -31,7 +31,7 @@ const totalCount = ref(0);
const showDelete = ref(false);
const showConfirmRetryAll = ref(false);
const showConfirmDeleteAll = ref(false);
const messageList = ref<IMessageList>();
const messageList = useTemplateRef<IMessageList>("messageList");
const messages = ref<ExtendedFailedMessage[]>([]);
const sortOptions: SortOptions<GroupOperation>[] = [
{
Expand Down
4 changes: 2 additions & 2 deletions src/Frontend/src/components/failedmessages/PendingRetries.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { onMounted, onUnmounted, ref, watch } from "vue";
import { onMounted, onUnmounted, ref, useTemplateRef, watch } from "vue";
import { licenseStatus } from "../../composables/serviceLicense";
import { connectionState } from "../../composables/serviceServiceControl";
import { usePatchToServiceControl, usePostToServiceControl, useTypedFetchFromServiceControl } from "../../composables/serviceServiceControlUrls";
Expand All @@ -24,7 +24,7 @@ const perPage = 50;
const cookies = useCookies().cookies;
const selectedPeriod = ref("All Pending Retries");
const endpoints = ref<string[]>([]);
const messageList = ref<IMessageList>();
const messageList = useTemplateRef<IMessageList>("messageList");
const messages = ref<ExtendedFailedMessage[]>([]);
const selectedQueue = ref("empty");
const showConfirmRetry = ref(false);
Expand Down