Skip to content

Replace the message header search with the filter component #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2025
Merged

Replace the message header search with the filter component #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04f54b9
Use filter component
soujay Apr 3, 2025
8e97c4a
Merge branch 'master' into header-filter-component
johnsimons Apr 3, 2025
709a65a
expose placeholder
soujay Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Frontend/src/components/FilterInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
<script setup lang="ts">
const model = defineModel<string>({ required: true });
defineProps({
placeholder: {
type: String,
default: "Filter by name...", // Default value
},
});
</script>

<template>
<div role="search" aria-label="filter" class="filter-input">
<input type="search" placeholder="Filter by name..." aria-label="filter by name" class="form-control-static filter-input" v-model="model" />
<input type="search" :placeholder="placeholder" aria-label="filter by name" class="form-control-static filter-input" v-model="model" />
</div>
</template>

Expand Down
11 changes: 5 additions & 6 deletions src/Frontend/src/components/messages/HeadersView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script setup lang="ts">
import { ExtendedFailedMessage } from "@/resources/FailedMessage";
import CopyToClipboard from "@/components/CopyToClipboard.vue";
import FilterInput from "@/components/FilterInput.vue";
import { computed, ref } from "vue";
const props = defineProps<{
message: ExtendedFailedMessage;
Expand All @@ -26,7 +27,9 @@ const filteredHeaders = computed(() => {
<div class="col">
<div class="text-search-container">
<div class="text-search">
<input type="search" aria-label="Filter by name" v-model="searchTerm" class="form-control format-text" placeholder="Search for a header key or value..." />
<div class="filter-group">
<FilterInput v-model="searchTerm" aria-label="Filter by name" :placeholder="'Search for a header key or value...'" />
</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -76,11 +79,7 @@ const filteredHeaders = computed(() => {
width: 100%;
max-width: 40rem;
}
.format-text {
font-weight: unset;
font-size: 14px;
min-width: 120px;
}

.filters {
background-color: #f3f3f3;
margin-top: 5px;
Expand Down